> On March 24, 2016, 6:25 a.m., David Rosca wrote: > > Please see https://git.reviewboard.kde.org/r/125088/. I myself am against > > blocking it, but there is a valid reason for it. > > > > Also, I think you can just remove the MouseArea (as Slider allows to change > > value with mouse wheel by default) instead of reimplementing the logic. > > Anthony Fieroni wrote: > I'm not removing MouseArea to not fooling the updateTimer, if it can > happen. Actual volume is changed in applet and kcm, current code of > src/kcm/package/contents/ui/VolumeSlider.qml is without MouseArea, i can > remove it. > Same code on 2 side => horrible nightmare
What's the problem with updateTimer? The code should be identical with KCM, except there is a MouseArea that blocks wheel events in applet. So if it doesn't work, it should be fixed there too. Regarding the wheel blocking, I think we should instead of blocking wheel on sliders block wheel to scroll view when mouse is on/above/below slider - enable scrolling only when mouse is on the sides (on the volume icon on the left and percent label on the right). That way we have wheel changing volume on sliders, don't have accidental volume change when scrolling but still are able to scroll the view on the sides. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93911 ----------------------------------------------------------- On March 23, 2016, 5:43 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127476/ > ----------------------------------------------------------- > > (Updated March 23, 2016, 5:43 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Repository: plasma-pa > > > Description > ------- > > I don't know why it's disabled, it's pretty handy > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 2e31eeb > > Diff: https://git.reviewboard.kde.org/r/127476/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
