On Dec. 30, 2015, 12:52 p.m., David Edmundson wrote: > > The rest LGTM. Thanks.
You're right it's unrelated. Removed for now. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/#review90338 ----------------------------------------------------------- On Dec. 30, 2015, noon, David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126576/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, noon) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Emitting objects in another object is generally bad practice. > > ShellCorona::availableScreenRect knows what properties of panelview we > use, so tracking of property changes should be in ShellCorona. > > > Diffs > ----- > > shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 > shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd > > Diff: https://git.reviewboard.kde.org/r/126576/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
