----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126576/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-workspace Description ------- Emitting objects in another object is generally bad practice. ShellCorona::availableScreenRect knows what properties of panelview we use, so tracking of property changes should be in ShellCorona. Diffs ----- shell/panelview.cpp 553dc7da30d2169b5c723926e0d610e846b077f7 shell/shellcorona.cpp 17ce61b57f71332b9b4029d44301462ef90d3dfd Diff: https://git.reviewboard.kde.org/r/126576/diff/ Testing ------- Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel