-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review88042
-----------------------------------------------------------

Ship it!


please fix the two added empty and then I think it's ready to go!


abstract_client.h (line 198)
<https://git.reviewboard.kde.org/r/125873/#comment60415>

    nitpick



shell_client.h (line 41)
<https://git.reviewboard.kde.org/r/125873/#comment60416>

    nitpick


- Martin Gräßlin


On Nov. 3, 2015, 5:37 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2015, 5:37 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> make the minimize effect work by reading taskGeometry from 
> plasmawindowmanagement and returning as iconGeometry().
> 
> It still supports a single taskbar as on x11. the architecture will have to 
> change somehow to allow to know from where panel we want to minimize (or if 
> not secified searching for the nearest panel)
> suggestions welcome :)
> 
> 
> Diffs
> -----
> 
>   abstract_client.h 128c141 
>   client.h f22e690 
>   shell_client.h fee22c4 
>   shell_client.cpp 79a1ac5 
> 
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to