> On Oct. 30, 2015, 3:32 p.m., Martin Gräßlin wrote: > > abstract_client.h, line 830 > > <https://git.reviewboard.kde.org/r/125873/diff/3/?file=413591#file413591line830> > > > > why friend an inheriting class? > > Marco Martin wrote: > because m_windowManagementInterface is private in AbstractClient (should > be protected?)
adding a protected method which returns it sounds like a better solution than friending - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125873/#review87746 ----------------------------------------------------------- On Oct. 30, 2015, 4:31 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125873/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2015, 4:31 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > make the minimize effect work by reading taskGeometry from > plasmawindowmanagement and returning as iconGeometry(). > > It still supports a single taskbar as on x11. the architecture will have to > change somehow to allow to know from where panel we want to minimize (or if > not secified searching for the nearest panel) > suggestions welcome :) > > > Diffs > ----- > > abstract_client.h 128c141 > client.h 4fbaa5f > shell_client.h fee22c4 > shell_client.cpp b466f97 > > Diff: https://git.reviewboard.kde.org/r/125873/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
