----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/#review86870 -----------------------------------------------------------
Cool, few tiny niggles. Then I think good to go. desktoppackage/contents/activitymanager/ActivityItem.qml (line 118) <https://git.reviewboard.kde.org/r/125626/#comment59748> comment that this is deliberate. I can predict someone "fixing" this. (I nearly wrote a comment) desktoppackage/contents/activitymanager/ActivityItem.qml (line 137) <https://git.reviewboard.kde.org/r/125626/#comment59744> the "\* 1" is rather redundant desktoppackage/contents/activitymanager/ActivityManager.qml (line 120) <https://git.reviewboard.kde.org/r/125626/#comment59749> I'm not sure I fully get this and I might be just talking nonsense, but I think you want horizontalScrollBarPolicy: Qt.ScrollBarAlwaysOff (which didn't exist when you first wrote this file) Then you can just do activityList { width: viewport.width } without the extra itemsWidth property desktoppackage/contents/activitymanager/StoppedActivityItem.qml (line 105) <https://git.reviewboard.kde.org/r/125626/#comment59745> if you're effectively making your own button you need http://doc.qt.io/qt-5/qml-qtquick-accessible.html stuff (name, role, selected and an onPressed ) same for the other delegate desktoppackage/contents/activitymanager/StoppedActivityItem.qml (line 140) <https://git.reviewboard.kde.org/r/125626/#comment59746> all icon only buttons need a tooltip for accessibility Also can we strip out some of the commented //iconSource: "" lines - David Edmundson On Oct. 13, 2015, 8:58 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125626/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 8:58 p.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-desktop > > > Description > ------- > > This is based on the VDG (Andrew's) mockup. > > - Activities have more contextual information > - Configuration and activity creation interface is the same as in activities > KCM > - Fixed the issue of plasma locking when Qt decides will-I-won't-I (the > relayout loop when it decides whether to show a scroll-bar or not) > > It requires the latest KActivities master. > > Latest: >  > > Previous: >  > > > Diffs > ----- > > desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e > desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 > desktoppackage/contents/activitymanager/ActivityItem.qml 526716c > desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 > desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 > desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f > desktoppackage/contents/activitymanager/Heading.qml be95b9e > desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f > desktoppackage/contents/activitymanager/static.js 0eaab96 > imports/activitymanager/switcherbackend.h 846862e > imports/activitymanager/switcherbackend.cpp 736fe67 > > Diff: https://git.reviewboard.kde.org/r/125626/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
