> On Oct. 13, 2015, 6:40 p.m., Ivan Čukić wrote: > > desktoppackage/contents/activitymanager/StoppedActivityItem.qml, line 47 > > <https://git.reviewboard.kde.org/r/125626/diff/1/?file=410892#file410892line47> > > > > Double smallSpacing on top and bottom. Yes, it is a bit... but it looks > > nicer.
maybe just add a comment about it - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125626/#review86817 ----------------------------------------------------------- On Oct. 13, 2015, 5:32 p.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125626/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 5:32 p.m.) > > > Review request for Plasma, David Edmundson and Marco Martin. > > > Repository: plasma-desktop > > > Description > ------- > > This is based on the VDG (Andrew's) mockup. > > - Activities have more contextual information > - Configuration and activity creation interface is the same as in activities > KCM > - Fixed the issue of plasma locking when Qt decides will-I-wount-I (the > relayout loop when it decides whether to show a scroll-bar or not) > > It requires the latest KActivities master. > > >  > > > Diffs > ----- > > desktoppackage/contents/activitymanager/ActivityDeletionDialog.qml 523aba6 > desktoppackage/contents/activitymanager/ActivityCreationDialog.qml 9317b0e > desktoppackage/contents/activitymanager/ActivityItem.qml 526716c > desktoppackage/contents/activitymanager/ActivityList.qml e8bf5f0 > desktoppackage/contents/activitymanager/ActivityManager.qml ff5cdc1 > desktoppackage/contents/activitymanager/ControlButton.qml 1e9854f > desktoppackage/contents/activitymanager/Heading.qml be95b9e > desktoppackage/contents/activitymanager/StoppedActivityItem.qml c1a417f > desktoppackage/contents/activitymanager/static.js 0eaab96 > imports/activitymanager/switcherbackend.h 846862e > imports/activitymanager/switcherbackend.cpp 736fe67 > > Diff: https://git.reviewboard.kde.org/r/125626/diff/ > > > Testing > ------- > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
