> On Okt. 13, 2015, 1:08 vorm., David Edmundson wrote: > > src/kcm/package/contents/ui/VolumeSlider.qml, line 86 > > <https://git.reviewboard.kde.org/r/125088/diff/2/?file=410693#file410693line86> > > > > I don't understand what this line is doing > > > > if we do block wheel events changing the slider's value, how will > > PulseObject.volume change? > > David Kahles wrote: > It doesn't change the volume. This is a try to implement what I wrote as > a comment above, so it tries to block the wheel events. > But I think this doesn't work as expected because the wheel events don't > get passed to the list. So the volume doesn't change once a slider gets focus > but nevertheless the scrolling is interrupted. > The only way I see (maybe there's a better way, don't know..) is the qt > patch https://codereview.qt-project.org/#/c/124669/. > > David Rosca wrote: > If we accept the wheel event here, it won't get propagated to the Slider > and won't change the value (basically block the wheel event, as is done in > applet - first issue). > The MouseArea is used only to get notified when the wheel event occurs > (it is not accepted, so it will get to Slider and change the value > accordingly) and then apply the changed value in onValueChanged.
Ahh sorry, I commented on the wrong issue. Please inore this comment^^ > On Okt. 13, 2015, 1:08 vorm., David Edmundson wrote: > > applet/contents/ui/ListItemBase.qml, line 203 > > <https://git.reviewboard.kde.org/r/125088/diff/2/?file=410692#file410692line203> > > > > why don't we have all the PendingWheelEvent stuff here? > > David Rosca wrote: > Because in applet the wheel scrolling on sliders is disabled, see first > review comment. I think this doesn't work as expected because the wheel events don't get passed to the list. So the volume doesn't change once a slider gets focus but nevertheless the scrolling is interrupted. The only way I see (maybe there's a better way, don't know..) is the qt patch https://codereview.qt-project.org/#/c/124669/. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review86769 ----------------------------------------------------------- On Okt. 13, 2015, 11:50 vorm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125088/ > ----------------------------------------------------------- > > (Updated Okt. 13, 2015, 11:50 vorm.) > > > Review request for Plasma and Harald Sitter. > > > Repository: plasma-pa > > > Description > ------- > > Implement changing volume on mouse wheel. > Also block wheel events on sliders in applet. > > Without this patch, the value of slider gets changed but it won't change the > actual volume. > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 8993b16 > src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 > > Diff: https://git.reviewboard.kde.org/r/125088/diff/ > > > Testing > ------- > > Changing volume with wheel works in kcm. Trying to use wheel on sliders in > applet does nothing. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
