----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review84949 -----------------------------------------------------------
I'm not sure whether we should enable scrolling in the applet at all. The problem I see occurs when you have at least 4 devices (For me this is a sound card with input and output, a hdmi output and a webcam, so nothing exotic). The device list is too long to be displayed in the systemtray without scrolling, but you can't really scroll down because the focus gets above a slider immediately, and thus the slider value changes. Therefore I think we should disable the scrolling in the systemtray. As QT doesn't offers an api for that, I created one but it's still under review (https://codereview.qt-project.org/#/c/124669/). What are other opioins on that? In the kcm, it should work as there is more space and the devices/applications are seperated in tabs, thanks for that. - David Kahles On Sept. 7, 2015, 12:58 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125088/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2015, 12:58 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Repository: plasma-pa > > > Description > ------- > > Implement changing volume on mouse wheel. > > Without this patch, the value of slider gets changed but it won't change the > actual volume. > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 8993b16 > src/kcm/package/contents/ui/VolumeSlider.qml c36dd33 > > Diff: https://git.reviewboard.kde.org/r/125088/diff/ > > > Testing > ------- > > Changing volume with wheel works in both applet and kcm > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
