> On Oct. 9, 2015, 10:51 a.m., Marco Martin wrote:
> > I tried it but unfortunately I have several issues with it:
> > * the first one, that may have avoided all the others: I discovered the 
> > existence of this thing just now. the default plasma theme is the one thing 
> > that
> > I'm sorry this looks like a complete refusal of it :( but again all of 
> > those could have been avoided with a different workflow
> > * It doesn't use the stylesheets, colors can't be dynamically changed (of 
> > all the issues, I consider this one the absolute showstopper).
> > * there are embedded images that are used just as references (like in 
> > button) this makes the files heavier to load
> > * actionbuttons won't work that way, it will break all round buttons that 
> > aren't radio buttons (as the checkmark won't be rendered correctly as well)
> > * I really don't like shadows of one single pixel, especially in the 
> > panel/popups (while i don't like the plasma theme trying too hard to look 
> > like the desktop theme, the depth of the shadow was the one thing that 
> > should have been either consistent or even a bit more, as they are at an 
> > higher z-order than the other woindows)
> > * besides being one single pixel, the shadow is wrong at the corner, the 
> > background is one pixel rounded, while the inner part of the shadow is 
> > square, leaving an hole of one pixel at the corner. On high dpi displays 
> > that would become very visible
> > * I really, really dislike the taskbar, looks cluttered and somewhat "old"

anyways, I think i'll try to write a simple script or app to batch convert 
monochrome icons to using stylesheets so even when icons from theme and from 
plasma are mixed the colors would be correct


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125568/#review86532
-----------------------------------------------------------


On Oct. 9, 2015, 8:28 a.m., Uri Herrera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125568/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 8:28 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> SVG elements done from scratch, reused only a small portion of the existing 
> files. Colors now match Breeze colorscheme. Buttons now match widget style. 
> Icons in the system tray are taken from the icon theme. Icons in Kickoff are 
> not monochromatic as only 16px and 22px icons are monochrome in Breeze. 
> Better padding overall for elements. New visual for both task manager widgets 
> that matches the states of the buttons. Checkboxes, raio buttons, sliders and 
> scrollbars now have the colors used in the Breeze colorscheme.
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://git.reviewboard.kde.org/r/125568/diff/
> 
> 
> Testing
> -------
> 
> ![Before](http://i.imgur.com/Cz2JNee.png)
> ![After](http://i.imgur.com/hiZlyrb.png)
> 
> ![Elements after](http://i.imgur.com/uMFsMzp.png)
> ![Elements before](http://i.imgur.com/pIs1CZ2.png)
> 
> 
> Thanks,
> 
> Uri Herrera
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to