----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125522/#review86460 -----------------------------------------------------------
Ship it! Tested it, works ok, for both kde4 and kf5. On the extra mouseRelease event, did you test removing it ? for both kde4 and kf5 ? If yes, feel free to remove it too (in which case the whole method can go). And yes: if it only is unnecessary for KF5, just ifdef it. Note: a similar patch should probably also be applied to kde/workspace/oxygen. Feel free to implement it there too and commit at will. I'll do it otherwise, in case you don't have time. Thanks again, Hugo - Hugo Pereira Da Costa On Oct. 7, 2015, 2:40 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125522/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 2:40 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Also remove hack that messes with cursor position, which results in window > sometimes rendered in wrong position for a moment after starting window move. > > I'm not sure why there was added a button release before ungrabbing pointer > in startDrag(), but it works fine without it. > > > Diffs > ----- > > kstyle/breezewindowmanager.h 7989052 > kstyle/breezewindowmanager.cpp a9ad7ee > > Diff: https://git.reviewboard.kde.org/r/125522/diff/ > > > Testing > ------- > > Moving windows still works. > I cannot reproduce the issue described in comment of the mentioned hack. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
