> On Oct. 7, 2015, 2:14 p.m., Hugo Pereira Da Costa wrote: > > Should also be checked when compiling against kde4 (cmake -DUSE_KDE4=1) > > As far as I can tell, right now it does not compile there. > > Also, concerning the added release, and other hacks, this was needed > > because in the past at least, when dragging the window, you would > > immediatly after miss one click as well as hover highlight. > > I'll double check if this is still the case (against kf5). > > Hugo Pereira Da Costa wrote: > ok. So against kf5 it seems to be working just fine indeed. > So just need fixing the compilation against kde4, as well as compilation > warnings > (namely: > > /home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp: > In member function ‘bool Breeze::AppEventFilter::appMouseEvent(QObject*, > QEvent*)’: > > /home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp:148:22: > warning: unused variable ‘window’ [-Wunused-variable] > QWidget* window( _parent->_target.data()->window() ); > ^ > > /home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp: > At global scope: > > /home/hpereira/kf5/src/kde/workspace/breeze/kstyle/breezewindowmanager.cpp:144:14: > warning: unused parameter ‘event’ [-Wunused-parameter] > bool appMouseEvent( QObject*, QEvent* event ) > ) > > Thanks !
So maybe only remove the hack for KF5? - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125522/#review86450 ----------------------------------------------------------- On Oct. 7, 2015, 2:40 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125522/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 2:40 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Also remove hack that messes with cursor position, which results in window > sometimes rendered in wrong position for a moment after starting window move. > > I'm not sure why there was added a button release before ungrabbing pointer > in startDrag(), but it works fine without it. > > > Diffs > ----- > > kstyle/breezewindowmanager.h 7989052 > kstyle/breezewindowmanager.cpp a9ad7ee > > Diff: https://git.reviewboard.kde.org/r/125522/diff/ > > > Testing > ------- > > Moving windows still works. > I cannot reproduce the issue described in comment of the mentioned hack. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
