> On Aug. 30, 2015, 2:10 p.m., Thomas Pfeiffer wrote: > > Usability-wise it's fine. > > Visually, the clear buttons for the shortcuts should be right-aligned > > Kai Uwe Broulik wrote: > They are? Or what are you referring to? > > David Edmundson wrote: > @Thomas, FYI if you click on the screenshot you can draw a rectangle over > bits you want to comment on > > Hugo Pereira Da Costa wrote: > I think (and am possibly wrong) that Thomas is talking about the fact > that the clear buttons of the first two lines in the list from the screenshot > are not aligned (neither left nor right) with the ones on all lines below. he > would make them right aligned across all lines in the list. > Also (and it is likely unrelated to this patch), what about the > horizontal alignment of the list with respect to the checkbox just above ? > > Kai Uwe Broulik wrote: > That's just QQ Layouts being weird, it pulls apart the two buttons of the > KeySequenceItem. I could only make the clear button stick to the other one. > > What's with the CheckBox? The old list was indented to show the checkbox > turns them all off, that doesn't neccessarily hold with the new TableView, > though.
> That's just QQ Layouts being weird, it pulls apart the two buttons of the > KeySequenceItem. I could only make the clear button stick to the other one. Does that mean it cannot be fixed? > What's with the CheckBox? The old list was indented to show the checkbox > turns them all off, that doesn't neccessarily hold with the new TableView, > though. https://techbase.kde.org/Projects/Usability/HIG/Alignment says "When options are subordinate to a check box or radio button (e.g. Audio level can only be set if the Activate Audio option is selected), this relation should be visualized by indenting the sub-options." - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124986/#review84584 ----------------------------------------------------------- On Aug. 29, 2015, 9:25 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124986/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2015, 9:25 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-workspace > > > Description > ------- > > In Plasma 4.x you could configure applet shortcuts from System Tray settings > rather fiddling around with each individual applet. This restores this. > > - It uses a TableView like the 4.x did (TableView is a good candidate for > pushing ComboBox off its throne of horribleness), including the item's icon > - Shortcuts in System Tray are now handled through QKeySequence rather than > QString > - When checking "Always show all entries" the comboboxes become disabled (not > the entire Table so you could still change shortcuts) > > > Diffs > ----- > > applets/systemtray/package/contents/ui/ConfigEntries.qml e848ae3 > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.h > f499a57 > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp > 6486f18 > applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.h 74d1e1f > applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 1528c7a > > Diff: https://git.reviewboard.kde.org/r/124986/diff/ > > > Testing > ------- > > I can set and unset applet shortcuts (did we have that for DBus tasks? There > were stubs for that but I can't remember), as well as hide/show/auto entries. > > > File Attachments > ---------------- > > UI in action > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/29/795452f7-f817-49d5-a2bb-ba43234f4f91__systemtrayshortcuts.png > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
