> On Aug. 28, 2015, 11:25 a.m., David Edmundson wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 83 > > <https://git.reviewboard.kde.org/r/124966/diff/1/?file=399467#file399467line83> > > > > if (XCB_EVENT_RESPONSE_TYPE(event->response_type) == XCB_FOCUS_OUT) > > Martin Gräßlin wrote: > what is that XCB_EVENT_RESPONSE_TYPE? > > David Edmundson wrote: > a macro that does ( & 0x7f) > > so the same as what you've written, but without needing weird magic > numbers. > > Martin Gräßlin wrote: > and where does it come from? I just added it to the source, but it > results in a nice compile error. > > David Edmundson wrote: > #include <xcb/xcb_event.h> > > Martin Gräßlin wrote: > that would introduce a new dependency XCB::Util which we do not yet use > in plasma-workspace. And there was a reason why I didn't use that in the past > anywhere (I just don't remember why).
Well that's convincing :P - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124966/#review84530 ----------------------------------------------------------- On Aug. 28, 2015, 11:17 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124966/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2015, 11:17 a.m.) > > > Review request for Plasma and Kåre Särs. > > > Repository: plasma-workspace > > > Description > ------- > > The screenlocker has always focus, the backend is sending it events. > So let's not allow X to tell Qt it doesn't have focus. > > > Diffs > ----- > > ksmserver/screenlocker/greeter/greeterapp.cpp > b500ba44c2b483d7372ca46840152c90ef5f798c > > Diff: https://git.reviewboard.kde.org/r/124966/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
