-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124966/#review84530
-----------------------------------------------------------



ksmserver/screenlocker/greeter/greeterapp.cpp (line 83)
<https://git.reviewboard.kde.org/r/124966/#comment58501>

    if (XCB_EVENT_RESPONSE_TYPE(event->response_type) == XCB_FOCUS_OUT)


does this actually work? the other window still has the actual focus we'll just 
keep happily blinking our cursor because we think we do.

if you do your krunner case and then type something after 10 seconds does it 
appear as you'd expect?

- David Edmundson


On Aug. 28, 2015, 11:17 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124966/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2015, 11:17 a.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> The screenlocker has always focus, the backend is sending it events.
> So let's not allow X to tell Qt it doesn't have focus.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.cpp 
> b500ba44c2b483d7372ca46840152c90ef5f798c 
> 
> Diff: https://git.reviewboard.kde.org/r/124966/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to