> On Srp. 20, 2015, 5:56 odp., Jan Grulich wrote: > > Doesn't look same, with your patch there is now quite a big space between > > details/plotter and the tab widget. > > Aleix Pol Gonzalez wrote: > It would be nice if both of you offered screenshots... :) > > David Edmundson wrote: > I offer maths! > > plot view was: > old code was 1g/3 + 1g/2 or in other words 5g/6 > > I changed it to large spacing which is 1g > > details view was: > 1g/3 + a non working 1g/3 > > again, I changed this to 1g. which is kinda off I guess. > > I'll redo it. > > Jan Grulich wrote: > Screenshots: >  > 
Hmm, I just noticed that even the axis labels are not now centered with the axis, which was the reason "probably" why I used different margins. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124841/#review84099 ----------------------------------------------------------- On Srp. 20, 2015, 7 odp., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124841/ > ----------------------------------------------------------- > > (Updated Srp. 20, 2015, 7 odp.) > > > Review request for Plasma and Jan Grulich. > > > Repository: plasma-nm > > > Description > ------- > > Plotter had a top margin of gridUnit / 2 > axis labels assumed a topMargin of gridUnit /3, so labels would > sometimes overlap the horizontal line. > > > Diffs > ----- > > applet/contents/ui/ConnectionItem.qml > 047cc9f3e4aefdd9457038ed312cdbae7e8f8a8f > > Diff: https://git.reviewboard.kde.org/r/124841/diff/ > > > Testing > ------- > > looks basically the same... > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
