----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124841/ -----------------------------------------------------------
Review request for Plasma and Jan Grulich. Repository: plasma-nm Description ------- Plotter had a top margin of gridUnit / 2 axis labels assumed a topMargin of gridUnit /2, so labels would sometimes clip the horizontal line. Both weren't needed anyway as as we can just increase the topMargin of the parent item instead (the one at line 285), so I did that and ported it to the more semantic largeSpacing at the same time. Also removed a topMargin in details view which had no top anchor so it wasn't doing anything. Diffs ----- applet/contents/ui/ConnectionItem.qml 047cc9f3e4aefdd9457038ed312cdbae7e8f8a8f Diff: https://git.reviewboard.kde.org/r/124841/diff/ Testing ------- looks basically the same... Thanks, David Edmundson
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel