----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review81434 -----------------------------------------------------------
I don't like that it now shows a timezone even when I have just one timezone selected which is pretty much redundant. Also, the tooltip always slides in from the left when I hover over the clock (some maximum width issue while it's not visible there or so?) rather than staying stationary. - Kai Uwe Broulik On Juni 10, 2015, 11:49 vorm., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124047/ > ----------------------------------------------------------- > > (Updated Juni 10, 2015, 11:49 vorm.) > > > Review request for Plasma. > > > Bugs: 348078 > https://bugs.kde.org/show_bug.cgi?id=348078 > > > Repository: plasma-workspace > > > Description > ------- > > In kde4 times, the layout of clock's tooltip was nicely arranged using a > table. Now it's a bit of a mess so this brings back the table. > > Also simplifies the timeForZone function which is used only for the tooltip. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 > applets/digital-clock/package/contents/ui/Tooltip.qml PRE-CREATION > applets/digital-clock/package/contents/ui/main.qml e814056 > > Diff: https://git.reviewboard.kde.org/r/124047/diff/ > > > Testing > ------- > > See screenshots. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png > After (custom tooltip delegate) > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/10/70f71cc7-3433-4a9a-bd12-031b82d6ed05__clock-tooltip9.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
