> On June 8, 2015, 9:20 p.m., Kai Uwe Broulik wrote: > > applets/digital-clock/package/contents/ui/DigitalClock.qml, line 452 > > <https://git.reviewboard.kde.org/r/124047/diff/1/?file=379315#file379315line452> > > > > I think you can clean this up a bit to not duplicate all those strings. > > Also, I don't think you should put all of this HTML formatting into the > > i18n, it lacks Qt.application.layoutDirection checks too. > > > > Something like > > returnString += "<tr><%1 > > align='right'>%2</%1><%1>%3</%1></tr>".arg(isCurrent ? "th" : > > "td").arg(timezoneString).arg(Qt.formatTime(dateTime, main.timeFormat)); > > Marco Martin wrote: > what about instead of HTML implementing a different layout delefate > instead? so that wouldbecome one single repeater and would perhaps be less > tricky for translations > > Martin Klapetek wrote: > Marco: I can try overriding the default tooltip if that's preferred
To me is fine anyways if this string is ok for i18n people. i guess so since this kind of html is used elsewhere too, just look easy to screw up having it broken in translations - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review81320 ----------------------------------------------------------- On June 8, 2015, 9:10 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124047/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 9:10 p.m.) > > > Review request for Plasma. > > > Bugs: 348078 > https://bugs.kde.org/show_bug.cgi?id=348078 > > > Repository: plasma-workspace > > > Description > ------- > > In kde4 times, the layout of clock's tooltip was nicely arranged using a > table. Now it's a bit of a mess so this brings back the table. > > Also simplifies the timeForZone function which is used only for the tooltip. > > > Diffs > ----- > > applets/digital-clock/package/contents/ui/DigitalClock.qml a142d33 > applets/digital-clock/package/contents/ui/main.qml e814056 > > Diff: https://git.reviewboard.kde.org/r/124047/diff/ > > > Testing > ------- > > See screenshots. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/62594835-6bbb-436d-ba88-f39cb98b3033__clock-tooltip4.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/06/08/fc93cc02-881b-4bca-96a5-e0356baf4e61__clock-tooltip3.png > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
