> On April 27, 2015, 2:56 p.m., David Edmundson wrote: > > Personally I don't think anyone needs to open the accounts KCM so often we > > need to link to it. I suspect it'll get more accidental opens than legit > > ones. > > > > The other changes seems good though. > > Lukáš Tinkl wrote: > I for one would expect it to be interactive, and it closely matches what > Windows (and Gnome Shell too afaik) does. > > Thomas Pfeiffer wrote: > By "User Account kcm" you mean the "Password and User Account" kcm, > right? I think that's okay, as it lets you edit the information that is shown > there. If we get lots of bug reports form people accidentally clicking it, we > might reconsider. > > Lukáš Tinkl wrote: > Yup exactly, it lets you edit what is being shown there - the user name > and your face/icon.
I must say that I quite like this idea, too. I've seen too many reviews where the user didn't bother to change the face icon in Kickoff, while it looks really cool and is a nice personalization point. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 ----------------------------------------------------------- On April 27, 2015, 5:04 p.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123530/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 5:04 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-desktop > > > Description > ------- > > This patch makes the user icon and search field clickable. Upon clicking the > former, the User Account kcm is opened, in the latter case the search field > gets visible and activated. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 > applets/kickoff/package/contents/ui/Header.qml dfabbe5 > > Diff: https://git.reviewboard.kde.org/r/123530/diff/ > > > Testing > ------- > > Everything works as expected, pressing Esc either cancels the search and/or > closes the menu popup. > > > Thanks, > > Lukáš Tinkl > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
