----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123530/#review79576 -----------------------------------------------------------
Personally I don't think anyone needs to open the accounts KCM so often we need to link to it. I suspect it'll get more accidental opens than legit ones. The other changes seems good though. - David Edmundson On April 27, 2015, 2:31 p.m., Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123530/ > ----------------------------------------------------------- > > (Updated April 27, 2015, 2:31 p.m.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-desktop > > > Description > ------- > > This patch makes the user icon and search field clickable. Upon clicking the > former, the User Account kcm is opened, in the latter case the search field > gets visible and activated. > > > Diffs > ----- > > applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde96 > applets/kickoff/package/contents/ui/Header.qml dfabbe5 > > Diff: https://git.reviewboard.kde.org/r/123530/diff/ > > > Testing > ------- > > Everything works as expected, pressing Esc either cancels the search and/or > closes the menu popup. > > > Thanks, > > Lukáš Tinkl > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
