----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ -----------------------------------------------------------
(Updated April 7, 2015, 5:20 nachm.) Review request for Plasma. Changes ------- Implemented suggestions by Kai Uwe Broulik. Thanks for the review :) Repository: kdeplasma-addons Description (updated) ------- Added tab "General" and "Appearance" in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make "Appearance" the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs (updated) ----- applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing ------- Tested using plasmashell directly and using plasmoidviewer File Attachments ---------------- Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
