----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78179 -----------------------------------------------------------
Awesome! A few nitpicks below File Attachment: snapshot5.png - snapshot5.png <https://git.reviewboard.kde.org//r/123164/#fcomment377> I wouldn't show the ID right at a glance. That's super geeky. Hide that in the details section. File Attachment: snapshot4.png - snapshot4.png <https://git.reviewboard.kde.org//r/123164/#fcomment378> Sending is more of an upload than a download, isn't it? File Attachment: snapshot4.png - snapshot4.png <https://git.reviewboard.kde.org//r/123164/#fcomment379> It's "Paired", what would "Connect" do? File Attachment: snapshot4.png - snapshot4.png <https://git.reviewboard.kde.org//r/123164/#fcomment380> Perhaps give the button a text, one could easily miss it. src/applet/package/contents/code/logic.js (line 54) <https://git.reviewboard.kde.org/r/123164/#comment53553> Nice ;) src/applet/package/contents/ui/BluetoothApplet.qml (line 37) <https://git.reviewboard.kde.org/r/123164/#comment53554> Would be cool to have the icon reflect the state, ie. use preferences-system-bluetooth-inactive (I think even the Plasma theme has that one) src/applet/package/contents/ui/BluetoothApplet.qml (line 45) <https://git.reviewboard.kde.org/r/123164/#comment53555> I don't think that's needed src/applet/package/contents/ui/ConfigGeneral.qml (lines 29 - 32) <https://git.reviewboard.kde.org/r/123164/#comment53556> Is it really neccessary to be able to turn sections off? src/applet/package/contents/ui/DeviceItem.qml (line 79) <https://git.reviewboard.kde.org/r/123164/#comment53557> Property starting with an uppercase letter looks wrong to me, I wonder why that even works. src/applet/package/contents/ui/FullRepresentation.qml (line 29) <https://git.reviewboard.kde.org/r/123164/#comment53559> Would it be possible to use Plasma's default proxy model? src/applet/plugin/devicesproxymodel.h (line 38) <https://git.reviewboard.kde.org/r/123164/#comment53560> virtual ~DevicesProxyModel() = default; ? src/applet/plugin/notify.cpp (line 37) <https://git.reviewboard.kde.org/r/123164/#comment53561> Use setIcon or setIconName or what it is called to avoid sending fixed pixmaps around. Also perhaps set the icon in the notifyrc, and perhaps a Bluetooth icon is more descriptive than a generic dialog-warning - Kai Uwe Broulik On März 29, 2015, 5:18 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123164/ > ----------------------------------------------------------- > > (Updated März 29, 2015, 5:18 nachm.) > > > Review request for Bluedevil and Plasma. > > > Repository: bluedevil > > > Description > ------- > > This is a replacement for bluedevil-monolithic. > The code is based on network management plasmoid and it does basically the > same but for Bluetooth devices. > > > Diffs > ----- > > CMakeLists.txt 94b56fb > src/CMakeLists.txt b804f2b > src/applet/CMakeLists.txt PRE-CREATION > src/applet/Messages.sh PRE-CREATION > src/applet/package/contents/code/logic.js PRE-CREATION > src/applet/package/contents/config/config.qml PRE-CREATION > src/applet/package/contents/config/main.xml PRE-CREATION > src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION > src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION > src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION > src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/Header.qml PRE-CREATION > src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION > src/applet/package/contents/ui/Toolbar.qml PRE-CREATION > src/applet/package/metadata.desktop PRE-CREATION > src/applet/plugin/CMakeLists.txt PRE-CREATION > src/applet/plugin/bluetoothplugin.h PRE-CREATION > src/applet/plugin/bluetoothplugin.cpp PRE-CREATION > src/applet/plugin/devicesproxymodel.h PRE-CREATION > src/applet/plugin/devicesproxymodel.cpp PRE-CREATION > src/applet/plugin/launchapp.h PRE-CREATION > src/applet/plugin/launchapp.cpp PRE-CREATION > src/applet/plugin/notify.h PRE-CREATION > src/applet/plugin/notify.cpp PRE-CREATION > src/applet/plugin/qmldir PRE-CREATION > src/bluedevil.notifyrc 72257ed > > Diff: https://git.reviewboard.kde.org/r/123164/diff/ > > > Testing > ------- > > I've been running it for some time already and it works fine. > > > File Attachments > ---------------- > > snapshot4.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png > snapshot5.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
