----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78160 -----------------------------------------------------------
src/applet/package/contents/ui/CompactRepresentation.qml (line 34) <https://git.reviewboard.kde.org/r/123164/#comment53541> you should be able to just anchors.fill: parent and icon item will do the right thing finding the iconsize and centering it. src/applet/package/contents/ui/Header.qml (line 42) <https://git.reviewboard.kde.org/r/123164/#comment53549> set left, right anchors and set eliding otherwise a long name is just going to leak out the box src/applet/package/contents/ui/SwitchButton.qml (line 1) <https://git.reviewboard.kde.org/r/123164/#comment53546> is this a direct copy from nm-qt? Maybe we could put it in plasmaextras? src/applet/package/contents/ui/SwitchButton.qml (line 42) <https://git.reviewboard.kde.org/r/123164/#comment53547> units.smallSpacing src/applet/package/contents/ui/SwitchButton.qml (line 46) <https://git.reviewboard.kde.org/r/123164/#comment53548> bottomMargin, topMargin are both unused in this case src/applet/package/contents/ui/Toolbar.qml (lines 84 - 87) <https://git.reviewboard.kde.org/r/123164/#comment53545> Kai/Bhushan there's an existing import that does this right? src/applet/plugin/devicesproxymodel.cpp (line 70) <https://git.reviewboard.kde.org/r/123164/#comment53544> micro optimise: fetch the names after you compare if connected differs - David Edmundson On March 28, 2015, 7:43 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123164/ > ----------------------------------------------------------- > > (Updated March 28, 2015, 7:43 p.m.) > > > Review request for Bluedevil and Plasma. > > > Repository: bluedevil > > > Description > ------- > > This is a replacement for bluedevil-monolithic. > The code is based on network management plasmoid and it does basically the > same but for Bluetooth devices. > > > Diffs > ----- > > CMakeLists.txt 94b56fb > src/CMakeLists.txt b804f2b > src/applet/CMakeLists.txt PRE-CREATION > src/applet/Messages.sh PRE-CREATION > src/applet/package/contents/code/logic.js PRE-CREATION > src/applet/package/contents/config/config.qml PRE-CREATION > src/applet/package/contents/config/main.xml PRE-CREATION > src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION > src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/ConfigGeneral.qml PRE-CREATION > src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION > src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/Header.qml PRE-CREATION > src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION > src/applet/package/contents/ui/Toolbar.qml PRE-CREATION > src/applet/package/metadata.desktop PRE-CREATION > src/applet/plugin/CMakeLists.txt PRE-CREATION > src/applet/plugin/bluetoothplugin.h PRE-CREATION > src/applet/plugin/bluetoothplugin.cpp PRE-CREATION > src/applet/plugin/devicesproxymodel.h PRE-CREATION > src/applet/plugin/devicesproxymodel.cpp PRE-CREATION > src/applet/plugin/launchapp.h PRE-CREATION > src/applet/plugin/launchapp.cpp PRE-CREATION > src/applet/plugin/notify.h PRE-CREATION > src/applet/plugin/notify.cpp PRE-CREATION > src/applet/plugin/qmldir PRE-CREATION > src/bluedevil.notifyrc 72257ed > > Diff: https://git.reviewboard.kde.org/r/123164/diff/ > > > Testing > ------- > > I've been running it for some time already and it works fine. > > > File Attachments > ---------------- > > snapshot4.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png > snapshot5.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
