> On Nov. 3, 2014, 2:44 p.m., Marco Martin wrote:
> > I think is the right way for Oxygen, since doesn't require any modification
> > to the kde4 version.
> > Breeze will need the same thing..
> > even tough perhaps would be better to just make the kde4 version of breeze
> > read/write into ~/.config as well, so they would just use the same config
> > file
>
> Martin Gräßlin wrote:
> changing the kde4 version is way more difficult as it's a stable release
> and we cannot control whether distros would ship the update.
>
> Marco Martin wrote:
> yeah, that's why i think this is right for oxygen, while for breeze is
> different, but that's ot here
>
> Hugo Pereira Da Costa wrote:
> "even tough perhaps would be better to just make the kde4 version of
> breeze read/write into ~/.config as well"
> @Marco
> since there now is a bug report about this for breeze.
> How can I achieve the above (that is: making the KDE4 version reading
> from/writing to KF5 version,
> rather than porting *this* change from oxygen to breeze ?
All instances of KSharedConfig::openConfig would need to be replaced with an
absolute path.
This path would have to come from qGetEnv("XDG_CONFIG_HOME"), falling back to
$HOME/.config if that's not set.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120957/#review69731
-----------------------------------------------------------
On Nov. 4, 2014, 3:11 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120957/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 3:11 p.m.)
>
>
> Review request for Plasma and Hugo Pereira Da Costa.
>
>
> Repository: oxygen
>
>
> Description
> -------
>
> Sync advanced settings to KDE4
>
>
> Diffs
> -----
>
> kstyle/config/oxygenstyleconfig.cpp 8185910
>
> Diff: https://git.reviewboard.kde.org/r/120957/diff/
>
>
> Testing
> -------
>
> Copies data correctly.
>
> Oxygen KDE4 apps update after reload.
> They don't update immediately but that bug is unrelated as that isn't
> happening when running "kcmshell4 style"
>
>
> Thanks,
>
> David Edmundson
>
>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
