> On Nov. 4, 2014, 12:21 p.m., Hugo Pereira Da Costa wrote: > > what about dependencies ? Are we happy with oxygen KF5 style always > > depending on Kdelibs4Migration ? (I don't know which framework it belongs > > to). > > Since the diff has no change in CMakeLists, I guess it must already be in > > the (at least indirect) dependencies. Any idea wherefrom ? And finally, > > should we try make this dependency 'optional' at compile time ?
> (I don't know which framework it belongs to). Rather suprisingly it's in KCoreAddons. I can't imagine we'll be getting rid of that soon :) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120957/#review69802 ----------------------------------------------------------- On Nov. 3, 2014, 2:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120957/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 2:24 p.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > ------- > > Sync advanced settings to KDE4 > > > Diffs > ----- > > kstyle/config/oxygenstyleconfig.cpp 8185910 > > Diff: https://git.reviewboard.kde.org/r/120957/diff/ > > > Testing > ------- > > Copies data correctly. > > Oxygen KDE4 apps update after reload. > They don't update immediately but that bug is unrelated as that isn't > happening when running "kcmshell4 style" > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
