-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122132/
-----------------------------------------------------------
(Updated Jan. 18, 2015, 7:53 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and KDE Usability.


Repository: plasma-workspace


Description
-------

This adds a new "Inhibition" source which has keys for each application 
(amarok, vlc, ...) and inside a QVariantMap with the pretty application name 
(taken from the desktop file through KService and cached locally), the 
application icon and the reason for the inhibition (as provided by the 
application)


Diffs
-----

  dataengines/powermanagement/powermanagementengine.cpp 2d370e6 
  dataengines/powermanagement/powermanagementengine.h a06fe7a 

Diff: https://git.reviewboard.kde.org/r/122132/diff/


Testing
-------

Works well, survives plasma reboots, and can now expose this information to the 
user in the battery monitor.

Adding usability just for feedback on the eventual user representation, see 
screenshot. It shows the application icon plus either "Amarok has disabled 
power management: Playing music" or in case of multiple inhibitions "Amarok and 
n other applications have disabled power management".


File Attachments
----------------

In action
  
https://git.reviewboard.kde.org/media/uploaded/files/2015/01/18/bd4c4b7c-89de-4ce6-9004-d480c2e1af57__pmdisabled3.png


Thanks,

Kai Uwe Broulik

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to