> On Dec. 11, 2014, 12:24 p.m., Marco Martin wrote: > > what's the status of this? > > Andrei Amuraritei wrote: > Hi there, this compiles and works, as best I could test it. Still needs > work to port away from kde4support libs. > Sadly my time with it has been null, too busy with work and other stuff > still. > > Marco Martin wrote: > can you push your work so far in a git branch? so is easy for people to > try, and eventually contribute ;) > > David Edmundson wrote: > As there has been no reply, I'm going to push this into master but leave > the dataengine commented out in the CMakeLists.txt. There's no point shipping > it till the plasmoid is done. > > To me the diff looks OK. Clearly a bit of work left, but what is here > seems good.
Sorry for not replying sooner, but I guess David did the better thing here. The engine works and I guess if people do really want to work on it (I still do), now they'll do it easier. On my part, I still need to get hold of the whole "devel" phase, so I'm slower. Thanks David. And Happy New Year to you all. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120276/#review71785 ----------------------------------------------------------- On Jan. 2, 2015, 1:30 p.m., Andrei Amuraritei wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120276/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2015, 1:30 p.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, Martin Klapetek, > and Sebastian Kügler. > > > Repository: kdeplasma-addons > > > Description > ------- > > comic DataEngine initial port to frameworks. > > > Diffs > ----- > > dataengines/CMakeLists.txt 04c7985 > dataengines/comic/CMakeLists.txt 8e382e6 > dataengines/comic/cachedprovider.h baac8a9 > dataengines/comic/cachedprovider.cpp caca25e > dataengines/comic/comic.h 8cc3969 > dataengines/comic/comic.cpp 7130f44 > dataengines/comic/comic_package.h 32be381 > dataengines/comic/comic_package.cpp 6d2ff0b > dataengines/comic/comic_package_plugin.cpp d997947 > dataengines/comic/comicprovider.h 630ee8d > dataengines/comic/comicprovider.cpp ab248a5 > dataengines/comic/comicproviderkross.h 46a9072 > dataengines/comic/comicproviderkross.cpp 9820f05 > dataengines/comic/comicproviderwrapper.h 81eee68 > dataengines/comic/comicproviderwrapper.cpp 48ced42 > > Diff: https://git.reviewboard.kde.org/r/120276/diff/ > > > Testing > ------- > > Building from source, compiles 100%, some deprecated warnings. DataEngine > shows up in plasmaengineexplorer and detects installed .comic packages. > This is the initial port, still need to review code to fix issues like > whitespaces around ( or the deprecated parts. > Thanks notmart, d_ed, sebas, bshas etc for helping. > > Update: Engine is working...still need to port away from Solid and KService > to remove KDELibs4Support, that is still wip. > > > Thanks, > > Andrei Amuraritei > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
