> On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.cpp, line 144 > > <https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line144> > > > > Just my opinion - > > > > An assert would be better since m_level is an enum and should NEVER be > > any other value apart from those 3.
+1 > On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.cpp, line 103 > > <https://git.reviewboard.kde.org/r/120777/diff/2/?file=330659#file330659line103> > > > > I'm a little confused. Where is this value being used? yeah, this doesn't look right. the query should be constructed in a way that only results within dates between startDate and endDate are considered. right now those values don't seem used at all? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70926 ----------------------------------------------------------- On Nov. 25, 2014, 3:11 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120777/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 3:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mobile > > > Description > ------- > > At the moment, Baloo doesn't provide a timeline, which is something that we > need for the activefilebrowser. > So this new component, is introducing support for the timeline. > > Notes > === > > * Baloocloud component contains the org.kde.baloo component inside it.The > reason behind that, is that the implementation for the timeline is kind of > terible because of its perfomance. > * I have put the new component inside the plasma-mobile repository, for the > above reason. But if the Baloo team, wants it inside the baloo repo then i > can move it. I am fine with both approaches (keep it here or in the baloo > repository. > * If someone has a better idea about the implementation, the pls shoot :) > > > > Diffs > ----- > > components/CMakeLists.txt 536b60e > components/timelinemodel/CMakeLists.txt PRE-CREATION > components/timelinemodel/qmldir PRE-CREATION > components/timelinemodel/timelinemodel.h PRE-CREATION > components/timelinemodel/timelinemodel.cpp PRE-CREATION > components/timelinemodel/timelineplugin.h PRE-CREATION > components/timelinemodel/timelineplugin.cpp PRE-CREATION > CMakeLists.txt 9466447 > > Diff: https://git.reviewboard.kde.org/r/120777/diff/ > > > Testing > ------- > > Everything looks ok. The performance is not bad, except from the fact that > the implementation is a bit of hackish... > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
