----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ -----------------------------------------------------------
Review request for Plasma. Repository: plasma-mobile Description ------- At the moment, Baloo doesn't provide a timeline, which is something that we need for the activefilebrowser. So this new component, is introducing support for the timeline. Notes === * Baloocloud component contains the org.kde.baloo component inside it.The reason behind that, is that the implementation for the timeline is kind of terible because of its perfomance. * I have put the new component inside the plasma-mobile repository, for the above reason. But if the Baloo team, wants it inside the baloo repo then i can move it. I am fine with both approaches (keep it here or in the baloo repository. * If someone has a better idea about the implementation, the pls shoot :) Diffs ----- components/baloocloudmodel/balootimelinemodel.h PRE-CREATION components/baloocloudmodel/balootimelinemodel.cpp PRE-CREATION components/baloocloudmodel/qmldir PRE-CREATION CMakeLists.txt 9466447 components/CMakeLists.txt 536b60e components/baloocloudmodel/CMakeLists.txt PRE-CREATION components/baloocloudmodel/baloocloudmodel.h PRE-CREATION components/baloocloudmodel/baloocloudmodel.cpp PRE-CREATION components/baloocloudmodel/baloocloudplugin.h PRE-CREATION components/baloocloudmodel/baloocloudplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120777/diff/ Testing ------- Everything looks ok. The performance is not bad, except from the fact that the implementation is a bit of hackish... Thanks, Antonis Tsiapaliokas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
