----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119220/ -----------------------------------------------------------
(Updated July 11, 2014, 5:33 p.m.) Review request for Plasma. Changes ------- I uploaded a new version of the patch as a file because reviewboard is not working well. I moved the uiReady variable to ContainmentPrivate, because it's the only place where it was being used. Then I moved the control code to ContainmentPrivate as well. Repository: plasma-framework Description ------- Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that the ui is ready. Make sure that if we loop through all the containments and they're all ready, we emit that it's done. So far, Corona::startupCompleted was never emitted. Diffs ----- src/plasma/corona.h baa9ee9 src/plasma/corona.cpp e18f081 src/plasma/private/applet_p.cpp 4fe27c9 Diff: https://git.reviewboard.kde.org/r/119220/diff/ Testing ------- File Attachments (updated) ---------------- pf-startup.patch https://git.reviewboard.kde.org/media/uploaded/files/2014/07/11/e5b15661-6507-441e-94cc-ed7828ab0ff9__pf-startup.patch Thanks, Aleix Pol Gonzalez
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel