-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119220/#review62094
-----------------------------------------------------------

Ship it!


It seems correct, just a little note.


src/plasma/private/applet_p.cpp
<https://git.reviewboard.kde.org/r/119220/#comment43184>

    when the code hits this path, uiready gets anyways set to true in line 333
    
    now, to be really precise is perhaps more correct setting uiready before 
emitting uiReadyChanged, but in this case the other uiready= true should be 
moved from line 333 to before line 326 as well to have the property set before 
signal in the other case as well


- Marco Martin


On July 10, 2014, 6:14 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119220/
> -----------------------------------------------------------
> 
> (Updated July 10, 2014, 6:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> Make sure AppletPrivate::uiReady is set in applet_p.cpp when we report that 
> the ui is ready.
> Make sure that if we loop through all the containments and they're all ready, 
> we emit that it's done.
> 
> So far, Corona::startupCompleted was never emitted.
> 
> 
> Diffs
> -----
> 
>   src/plasma/corona.h baa9ee9 
>   src/plasma/corona.cpp e18f081 
>   src/plasma/private/applet_p.cpp 4fe27c9 
> 
> Diff: https://git.reviewboard.kde.org/r/119220/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to