> On July 10, 2014, 6:36 p.m., Shantanu Tushar wrote: > > My only problem with this is that its inconsistent with the Up/Down arrow > > key combination that we have in MediaPlayer. Also, you can't make the > > player also use Ctrl+Arrow keys because then a remote control won't work. > > I'd suggest just making sure that the standard media keys work (play,pause > > etc) so that people can, for example, pause stuff when they get a phone > > call. To control the volume they can always press Esc and Up/Down. > > R.Harish Navnit wrote: > Why is it inconsistent ? I mean I'm able to use both(just the arrow keys > and the combination). I've no idea of how a remote control would affect > things so I don't know what that would require. > I think the standard media keys do work. Yes, you can play/pause, no > problems there. but are you suggesting that I use the combination "Esc + > Up/Down" ? Well, I think that's inconsistent since the Esc key is being used > as a shortcut to go to the previous screen. However, we do have the backspace > key doing the same. I could change that if that's what you mean ? > > P.S: I'm not sure if I've got what you're trying to convey. Is what I > mentioned above right ? > > Shantanu Tushar wrote: > Its inconsistent because the player needs only Up/Down (try it) but this > one needs Ctrl as well (ideally you'd want the same shortcuts everywhere). > Remote control concept is simple, every action should be possible use arrow > keys, enter, esc. I meant you can press Esc from the home screen to go to the > player, and then Up/Down to control the volume. > > R.Harish Navnit wrote: > Yes, the player volume can be controlled using the arrow keys, but they > won't work when you're not in the player screen. The user can get away if > he's in the home screen, but if the user was, let's say browsing through his > pictures collection then pressing the Esc key is not really a good choice(3/4 > presses of Esc key would take you to the player and only then would pressing > the arrow key work), isn't that inconvenient ? > > We can have the same shortcuts everywhere(merely arrows won't work, since > they're used for navigation in the homescreen etc), we could have a > combination for the same, if not "ctrl + arrows", how about using shift ? Do > you have any suggestions ?
Yep, those are the media volume up/down keys (assuming your keyboard has them). - Shantanu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119219/#review62090 ----------------------------------------------------------- On July 10, 2014, 6:16 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119219/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 6:16 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > AFAIK, volume of a playing media cannot be controlled from the HomeScreen. > This patch enables increasing and decreasing the volume using the combination > of "Ctrl + Up/Down" keys. > > > Diffs > ----- > > shells/newshell/package/contents/ui/mediacenter.qml > 15c9cee7f86573939ac92872fb2201d944e0589f > > Diff: https://git.reviewboard.kde.org/r/119219/diff/ > > > Testing > ------- > > Use the "ctrl + up/down" keys to increase/decrease the volume of the current > playing media. seems to work fine. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
