----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119219/#review62090 -----------------------------------------------------------
My only problem with this is that its inconsistent with the Up/Down arrow key combination that we have in MediaPlayer. Also, you can't make the player also use Ctrl+Arrow keys because then a remote control won't work. I'd suggest just making sure that the standard media keys work (play,pause etc) so that people can, for example, pause stuff when they get a phone call. To control the volume they can always press Esc and Up/Down. - Shantanu Tushar On July 10, 2014, 6:16 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119219/ > ----------------------------------------------------------- > > (Updated July 10, 2014, 6:16 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > AFAIK, volume of a playing media cannot be controlled from the HomeScreen. > This patch enables increasing and decreasing the volume using the combination > of "Ctrl + Up/Down" keys. > > > Diffs > ----- > > shells/newshell/package/contents/ui/mediacenter.qml > 15c9cee7f86573939ac92872fb2201d944e0589f > > Diff: https://git.reviewboard.kde.org/r/119219/diff/ > > > Testing > ------- > > Use the "ctrl + up/down" keys to increase/decrease the volume of the current > playing media. seems to work fine. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
