----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/ -----------------------------------------------------------
(Updated June 19, 2014, 7:56 p.m.) Status ------ This change has been discarded. Review request for Plasma. Repository: plasma-workspace Description ------- This adds the following improvements provided by Review 117339 and Review 117540: - Show temperature, voltage, energy rate and serial number. Since those are only shown when expanding the battery it's imho not that bad to show some geeky stuff which can give you some more indication of battery health and overall power consumption. It adds new strings, however. It also changes the substr hackery to "enabled: false" for greying out the labels. What's the preferred way of formatting numbers (decimal points, units)? The formats thing only seems to be for file sizes and durations. Diffs ----- applets/batterymonitor/contents/code/logic.js 5b4cb52 applets/batterymonitor/contents/ui/BatteryItem.qml 431aa9a applets/batterymonitor/contents/ui/CompactRepresentation.qml 39cd331 applets/batterymonitor/contents/ui/DetailsLabel.qml d973d22 applets/batterymonitor/contents/ui/PopupDialog.qml 0444199 applets/batterymonitor/contents/ui/batterymonitor.qml 4711c5e Diff: https://git.reviewboard.kde.org/r/117542/diff/ Testing ------- Compiles. Information is properly displayed when expanding a battery. Thanks, Kai Uwe Broulik
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
