> On April 23, 2014, 4:49 p.m., David Edmundson wrote: > > applets/batterymonitor/contents/code/logic.js, line 33 > > <https://git.reviewboard.kde.org/r/117542/diff/1/?file=265148#file265148line33> > > > > Can you explain this change?
See the other reviews where I renamed this property because it always confused me. Plugged doesn't mean plugged in as in charging but plugged into the battery bay (ie. *present* in it). That's just a cosmetic change and SIC for Frameworks 5.0 so I could drop that all the way. > On April 23, 2014, 4:49 p.m., David Edmundson wrote: > > applets/batterymonitor/contents/ui/BatteryItem.qml, line 290 > > <https://git.reviewboard.kde.org/r/117542/diff/1/?file=265149#file265149line290> > > > > it would be good to see if we can use something better than != 0 > > > > 0 is a perfectly valid temperature. For two batteries an energy rate > > could be 0. > > > > using !== might work out well. Indeed, though my battery always reports 0 which is clearly wrong but upower doesn't have means to report that it doesn't actually *know* the value. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117542/#review56298 ----------------------------------------------------------- On April 13, 2014, 1:45 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117542/ > ----------------------------------------------------------- > > (Updated April 13, 2014, 1:45 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This adds the following improvements provided by Review 117339 and Review > 117540: > - Show temperature, voltage, energy rate and serial number. Since those are > only shown when expanding the battery it's imho not that bad to show some > geeky stuff which can give you some more indication of battery health and > overall power consumption. It adds new strings, however. It also changes the > substr hackery to "enabled: false" for greying out the labels. > > What's the preferred way of formatting numbers (decimal points, units)? The > formats thing only seems to be for file sizes and durations. > > > Diffs > ----- > > applets/batterymonitor/contents/code/logic.js 5b4cb52 > applets/batterymonitor/contents/ui/BatteryItem.qml 431aa9a > applets/batterymonitor/contents/ui/CompactRepresentation.qml 39cd331 > applets/batterymonitor/contents/ui/DetailsLabel.qml d973d22 > applets/batterymonitor/contents/ui/PopupDialog.qml 0444199 > applets/batterymonitor/contents/ui/batterymonitor.qml 4711c5e > > Diff: https://git.reviewboard.kde.org/r/117542/diff/ > > > Testing > ------- > > Compiles. Information is properly displayed when expanding a battery. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
