> On June 11, 2014, 6:18 p.m., Rex Dieter wrote: > > Tested this out a bit today... and it didn't seem to work all that well. > > Did seem to result in too much whitespace at times, and was fairly easy to > > get plasma into a state where it would endlessly try to resize things to > > fit. Helped a bit to reduce my "small" font in systemsettings to something > > smaller, but the code really ought to be more robust against that situation. > > Yichao Zhou wrote: > Could you give a screenshot and the font name so I can give some help? > > Rex Dieter wrote: > My testing and resizing resulted was primarily when using the digital > clock's show "long date" option, sorry I failed to mention that. > > Yichao Zhou wrote: > OK. Long date seems to have some problems on my system: space at top > and bottom is not even. Is that you problem? Also, it will be better if you > could provide a screenshot. Still, please provide your font name... > > Rex Dieter wrote: > The top/bottom spacing isn't pleasing sometimes, indeed, but I could live > with that. > > I've tested with both Dejavu Sans and (google) Arimo fonts. The main > problem I'm worried about is adjusting panel height sometimes results in the > clock applet continually redrawing/resizing/reformatting itself to fit > (something a screenshot cannot capture).
That's strange. This patch does not modifiy the redraw mechanism of the widget. It just changes the method of calculating the width of text, i.e. using 00:00:00 get the width. Are you sure this does not happen before this patch? I just cannot reproduce your problem... Maybe you can provide a video to demonstrate this problem. However, I just suspect whether the developer still interests in merging this patch since they seems to be busy with KDE5, which uses a completely different applet system. - Yichao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review59821 ----------------------------------------------------------- On March 18, 2014, 12:56 p.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115431/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 12:56 p.m.) > > > Review request for Plasma. > > > Bugs: 228902 > http://bugs.kde.org/show_bug.cgi?id=228902 > > > Repository: kde-workspace > > > Description > ------- > > For bug, see > https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and > https://bugs.kde.org/show_bug.cgi?id=228902 > > The problem is that in original code, it always uses 23:59 to calculate the > width of the text. However, in some font, AM is wider than PM, and 0 is > wider than 2 and 5. That causes some fonts been cropped. > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.cpp f26e328 > > Diff: https://git.reviewboard.kde.org/r/115431/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
