> On June 5, 2014, 8:36 a.m., Thomas Pfeiffer wrote: > > Usability review: > > Since I lack the skills to picture it from the diff: When exactly is the > > notification shown? Is it shown as soon as the media is supposed to be > > played? If so, I think it could be done in a more subtle way: Grey out the > > entry in the playlist and just skip over it to the next entry int he > > playlist (like Amarok does) and show the message in a tooltip on mouseover > > on a pointer device or on tap on a touch device. > > If it's already done in a similar way, then it's fine for me ;) > > R.Harish Navnit wrote: > I've added a screenshot which should help. This is a little different > from the way amarok deals with the same error. If the media is inaccessible, > the message is shown in the player screen. > Is it okay, If I go ahead in the way I am or should look to implement > something similar to what amarok does ?? > > Thomas Pfeiffer wrote: > Does PMC really have to be restarted to detect that the location is now > accessible? That's not really a nice situation. > The whole message seems overly dramatic to me, especially in a playlist. > Imagine you have a playlist with 50 songs in it, and three of them are on a > location which isn't accessible. What would you prefer? > a) Having to close PMC, make the location accessible and then restart it > b) Just skip over those three songs and happily listen to the other 47 > > If we're not in a playlist, the problem should rarely occur because the > browser only shows currently accessible media anyway, right? > > > R.Harish Navnit wrote: > So, like I'd mentioned in the mail(sorry about that). > > 1.PMC need not be restarted to get to detect that the location is > accessible. I think the message might have been ambiguous. The user is > expected to mount > all drives containing media and then run the application again. > 2. You can skip over to the next media in a playlist. That's how I > envisage the fix. > > Please let me know things have to be done differently. > > Thomas Pfeiffer wrote: > The problem is that currently, the message is very scary. The skip > controls are still active, but the user is presented with that very prominent > error message telling her that she has to make sure that the file becomes > accessible and restart the application. Plus, the playlist won't continue > unless the user actively skips to the next entry, right? > The way Amarok does it is way less scary and disruptive since it silently > skips. The only problem with Amarok's solution is that there is no way to > find out why it skipped. That's why I suggested to offer a tooltip so users > who wonder why a track was skipped can find out what the problem is. The > message showing up in the tooltip could be like the one you've proposed, > though I would change it to "Could not open the file [path]. To play this > file, make sure it is accessible and restart Plasma Mediacenter" > > > Shantanu Tushar wrote: > Bah, this skipped me as well. There is absolutely no need to restart the > app here, if the file is available, simply clicking play again should work. > > Also, after Thomas pointed it out, in a playlist it actually makes sense > to simply skip the missing media. However, if you play a single media > (without the playlist) then this message seems appropriate. > @Thomas, does that sound right? > > Finally, I'd suggest "and try again", insteasd of "and restart the > application". > > R.Harish Navnit wrote: > I find another discrepancy here, simply play again doesn't work even if > the file is available(after initially being inaccessible). There is no need > to restart the app here, but the only way that I'm able to play the media is > by playing either the next or previous media and then returning to the > current media. Clicking play again doesn't seem to work for me. I don't find > this too much of an issue btw, just reported though. > > From the discussions that we've had ^^, I'm inferring that it is expected > that this fix works similar to the way in which amarok handles the same > situation, and I shall proceed along the same lines. > > Shantanu Tushar wrote: > Well then its a bug, ideally clicking play again should work. This review > should only go in once that bug is fixed imo (because it should change > "please restart" to "please try again") > > About the behavior, in my previous comment I have suggested that this > error should only come when the played media is *not* in the current > playlist. If it is in playlist, we should silently skip it.
Okay, I'll look into that. I might not be able to work this week, but next week looks fine ;) - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review59281 ----------------------------------------------------------- On June 5, 2014, 8:47 a.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118406/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 8:47 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 333764 > http://bugs.kde.org/show_bug.cgi?id=333764 > > > Repository: plasma-mediacenter > > > Description > ------- > > If a media(in a playlist) is located in an inaccessible location, then the > user is notified about the same. > > > Diffs > ----- > > mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c > > Diff: https://git.reviewboard.kde.org/r/118406/diff/ > > > Testing > ------- > > 1. Load media to a playlist. > 2. Unmount the device containing media. > 3. Check if the user is notified of the location being inaccessible > --yes, the user is notified > 4. Mount the device containing media and play a media from playlist. > -- The media plays properly. > > > File Attachments > ---------------- > > wihtout_i18n.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/05/3dc148a5-c4da-4d27-a713-e63922cbcef8__wihtout_i18n.png > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
