----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118406/#review59281 -----------------------------------------------------------
Usability review: Since I lack the skills to picture it from the diff: When exactly is the notification shown? Is it shown as soon as the media is supposed to be played? If so, I think it could be done in a more subtle way: Grey out the entry in the playlist and just skip over it to the next entry int he playlist (like Amarok does) and show the message in a tooltip on mouseover on a pointer device or on tap on a touch device. If it's already done in a similar way, then it's fine for me ;) - Thomas Pfeiffer On June 3, 2014, 5:05 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118406/ > ----------------------------------------------------------- > > (Updated June 3, 2014, 5:05 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 333764 > http://bugs.kde.org/show_bug.cgi?id=333764 > > > Repository: plasma-mediacenter > > > Description > ------- > > If a media(in a playlist) is located in an inaccessible location, then the > user is notified about the same. > > > Diffs > ----- > > mediaelements/mediaplayer/MediaPlayer.qml 98f1d2c > > Diff: https://git.reviewboard.kde.org/r/118406/diff/ > > > Testing > ------- > > 1. Load media to a playlist. > 2. Unmount the device containing media. > 3. Check if the user is notified of the location being inaccessible > --yes, the user is notified > 4. Mount the device containing media and play a media from playlist. > -- The media plays properly. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
