> On March 22, 2014, 11:09 p.m., Mark Gaiser wrote: > > Is there still an intention on getting this in KDE 4.xx? > > Just wondering since it seems to be much better then the current kmix popup. > > Christian Esken wrote: > I also haven't heard about further development here. Diego as original > submitter or somebody else would have to push this. I added this as a topic > for the KDE Multimedia Sprint. It takes place in about 4 months (August > 2014): https://sprints.kde.org/sprint/212 > > Diego Casella wrote: > My bad, sorry guys but I'm still in a busy period of my life :/ > I'll try to fix the remaining issues pointed out in this review request, > and then submit the changes here. > There is still an ongoing (and BIG imho) issue anyway: we really really > really need a Plasma QML callback to capture mouse scroll events. AFAIK there > still isn't in both Plasma 4.13 and also Plasma Next. And talking about kmix > applet, one feature everyone is using is the ability to adjust volume level > with just few mouse scrolls over the applet icon. > I think we need to fix this problem as well, what do you think? > > Christian Esken wrote: > Yes, most definitely we should have mouse scroll events. I guess > everybody is using it on the tray icon and in the main window, and so it > should also be there for the applet. > But if users can choose the plasmoid as an optional, then this is not a > showstopper. It is probably better to get it started as is. We could mark it > "early-access", so interested people can start playing around with it and > using it. > > Mark Gaiser wrote: > Quote: "There is still an ongoing (and BIG imho) issue anyway: we really > really really need a Plasma QML callback to capture mouse scroll events...." > Seriously? > > I never ever used the scrolling on the tray icon itself. I didn't even > know it was possible till you said it in this post. > But please don't let such a minor issue block your progress :) > > Clicking the icon or using the media keys on most keyboards is probably > enough possibilities for people change the volume. Scrolling on the icon is > imho just bonus stuff. > > Martin Klapetek wrote: > > Clicking the icon or using the media keys on most keyboards is probably > enough possibilities for people change the volume. Scrolling on the icon is > imho just bonus stuff. > > I use it extensively and every new user I put on Plasma, that's one of > the first things I teach them. It's much more convenient because ~80% of the > time you're holding your mouse in your hand and ~95% of the time you have > your eyes on the screen. Going for keyboard button means in many cases taking > your eyes off the screen and looking at the exact button position, often you > even have to let the mouse go and move your hand to keyboard (for example > YouTube video/any other media being too loud). > > Mark Gaiser wrote: > But you can do it all with your mouse. > 1. Click the icon > 2. move your cursor to the stream (or master channel). > 3. scroll... > > Just to be sure, scrolling (as i described in the steps above) works in > this proposed component, right? > All that's not working is scrolling on the tray icon, correct? > > Note: I happen to have a keyboard without media keys. I always click the > icon and scroll on the stream where i want to change the sound level. > > Martin Klapetek wrote: > Sure you can, it's just way easier to simply scroll on an icon than > opening this -> http://i.imgur.com/LcyFzq6.png and identifying the channel > you need to change (the assumption being that you want to change only the > main volume, not per stream controls). That way you're doing the visual > identification twice - first locating the systray icon, <click>, now locating > the proper handle. So doing it that way is mentally harder task than simply > scroll the icon, which also saves you a click ;) > > Diego Casella wrote: > @Mark Gaiser: volume change on scroll is a very, very, handy and smart > feature (Martin's answer sums up everything nicely): it would be a pity if we > lose it because of a lack in the Plasma QML bindings. By the way, an other > plasma applet which uses such feature is, for example, the clock applet: it > uses mouse scrolls to loop between timezones (if selected by the user), which > is handy for example to check the UTC time before an IRC meeting ;) > Besides, you're the first person who _wasn't_ aware of that feature :P > As last resort, if we can't come up with a proper solution to whether add > this feature back or not, I could blog about it and open a poll to planetkde > readers, in order to collect as much feedbacks as possible, what do you think? > > Mark Gaiser wrote: > Quote: "By the way, an other plasma applet which uses such feature is, > for example, the clock applet: it uses mouse scrolls to loop between > timezones (if selected by the user), which is handy for example to check the > UTC time before an IRC meeting ;)" > > Sorry, but that is truly one of the most annoying features in the clock > applet ever introduced. It's unexpected, often happens by accident and really > annoys users! I've even had it a few times when my time was changed and i > actually thought it was _the_ current time. We've talked about that specific > feature at last years pim sprint and basically decided that the feature > should go. Someone just needs to take the time to make a patch for it. That > the feature is there is "oke" but that UTC is enabled by default is _not_ ok. > I can see and understand it's use for volume control though. > > Sebastian Kügler wrote: > To me, the scrolling on the panel icon is fine. We've had this feature > forever, it has some real usecases, and it would probably initiate some > serious backlash from our users if we just removed it. > > It's not a blocker.
Just a ping to have some feedback from the reviewers :) - Diego ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112208/#review53775 ----------------------------------------------------------- On May 4, 2014, 9:46 p.m., Diego Casella wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/112208/ > ----------------------------------------------------------- > > (Updated May 4, 2014, 9:46 p.m.) > > > Review request for Plasma, Aaron J. Seigo, Christian Esken, Marco Martin, and > Igor Poboiko. > > > Repository: kmix > > > Description > ------- > > KMix qml applet. > As you can see from the screenshot, the applet is pretty much functional: you > can display all the controls available, change its orientation, and decide to > whether show all of them or just the Master Control, and refresh its status > when new controls are added/removed/updated (such as Amarok current playing > track). See screenshots below :) > Differences from the old kmix tray: > * no media player controls ( I never investigated how to get them, but > honestly opening the audio applet to change/skip/pause audio track makes > little sense to me ... if anyone wants this feature back, don't be shy and > step in); > * the button used to select which Mixers are visible has been changed to open > Phonon kcm page: since visible mixers are already configurable from KMix app, > having a button to show KMix *and* a button to modify Mixers visibilty made > little sense here too, so I preferred to give more visibility to Phonon kcm; > > Known issues: > * there is still no way to get notified of mouse wheel events over the > popupIcon, so it is not possible to scroll over to increase/decrease the > master control volume; > * no scroll events over the sliders too; > * if you want to use the applet you most likely will disable KMix tray icon > but, if you do so, KMix will show its GUI at every login and you have to > close it manually. This requires KMix to be patched. Furthermore, if you > click "KMix Setup" button, KMix window will not restored anymore: this needs > to be pathed as well. > * resize doesn't work properly. > > > Diffs > ----- > > plasma/kmix-applet-qml/contents/ui/HorizontalControl.qml 7e87c8e > plasma/kmix-applet-qml/contents/ui/HorizontalMixerListDelegate.qml 26f2968 > plasma/kmix-applet-qml/contents/ui/MixersList.qml 66bda73 > plasma/kmix-applet-qml/contents/ui/VerticalControl.qml 1702be7 > plasma/kmix-applet-qml/contents/ui/VerticalMixerListDelegate.qml bab9ac6 > plasma/kmix-applet-qml/contents/ui/kmixapplet.qml eecb91c > > Diff: https://git.reviewboard.kde.org/r/112208/diff/ > > > Testing > ------- > > Tested against master and works fine. > > > File Attachments > ---------------- > > Default look > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet.png > Menu Actions > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet1.png > Applet Config Options > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet2.png > Vertical Control > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/22/kmix_applet3.png > ToolButton label and Config page after updates > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/24/kmix_applet5.png > Control Icon and Label left aligned > > https://git.reviewboard.kde.org/media/uploaded/files/2013/08/27/kmix_applet6.png > Kmix, horizontal view > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/9d6b0ca4-5a75-45cc-ab8e-61b13d4079e6__kmix_horizontal_new.png > Kmix applet, vertical view > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/04/7efb308a-c306-47c2-883f-64d1f32db5b5__kmix_vertical_new.png > > > Thanks, > > Diego Casella > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
