> On May 12, 2014, 1:04 p.m., Aleix Pol Gonzalez wrote:
> > That's not correct. Primary, at least, needs to have special treatment and 
> > get the 0-named containment assigned always, which is what the current 
> > naming is about.
> > 
> > As for the rest of the screens it's probably best to sort them rather than 
> > keeping them as they come like now. Furthermore, you'll want also to insert 
> > the new screens in the correct position then, and shift the rest of the 
> > screens.
> >

> That's not correct. Primary, at least, needs to have special treatment and 
> get the 0-named containment assigned always, which is what the current naming 
> is about.

Why?

> As for the rest of the screens it's probably best to sort them rather than 
> keeping them as they come like now.

They are sorted from left to right...or what sorting you have in mind?

> Furthermore, you'll want also to insert the new screens in the correct 
> position then, and shift the rest of the screens.

Yes.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118094/#review57757
-----------------------------------------------------------


On May 12, 2014, 12:39 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118094/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 12:39 p.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Even though numbered outputs have their flaws, we still use them pretty much 
> everywhere and everywhere we use outputs numbered from left to right, so 
> let's use the same in Plasma.
> 
> This seems to fix most of my multiscreen issues now, namely bug 334500 and 
> bug 334502.
> 
> Also:
> 
> <mgraesslin> I don't know - having primary as 0 is a bit strange
> <mgraesslin> 1, 2, 3, 0
> <mgraesslin> ?
> <mgraesslin> that was from left to right
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp b0b139d 
> 
> Diff: https://git.reviewboard.kde.org/r/118094/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to