> On May 7, 2014, 9:31 p.m., Thomas Pfeiffer wrote: > > Okay, usability review. Some recommendations, some questions: > > - This right now only has these options because adding wallpapers or > > Plasmoids simply wasn't implemented yet and will get more settings once > > they are implemented, right? > > - In which category will it reside? In 4.X it is in "Display & Monitor" and > > thus in the Hardware category, where it certainly should not be because it > > has nothing to do with hardware. It should go into workspace settings > > - "Immediate" should say "Immediately" > > - I think Sebas' suggestion to use comboboxes makes sense, but it would > > make even more sense to use editable comboboxes, which would combine the > > ease of selecting one of a few values with the flexibility of being able to > > enter an arbitrary number. What's saved in the config file would always be > > a number. > > - Why is "Lock screen after" in minutes, but "Require password after" in > > seconds? Is it because it the latter is only supposed to be a grace time to > > allow users to move the mouse to prevent having to enter the password when > > they see the screen has locked? > > - The GUI (just like the 4.x one) does not make clear whether "Require > > password after" means "After the last user action" or "After the screen was > > locked". I'd write "Require password after locking:". This is still not > > 100% clear, but should be more clear than it is now. > > - Is "Logout automatically after" really useful? do we know of realistic > > usecases for this feature? Otherwise, I'd remove it. > >
> - This right now only has these options because adding wallpapers or > Plasmoids simply wasn't implemented yet and will get more settings once they > are implemented, right? yes > - In which category will it reside? In 4.X it is in "Display & Monitor" and > thus in the Hardware category, where it certainly should not be because it > has nothing to do with hardware. It should go into workspace settings done > - "Immediate" should say "Immediately" done > - Why is "Lock screen after" in minutes, but "Require password after" in > seconds? Is it because it the latter is only supposed to be a grace time to > allow users to move the mouse to prevent having to enter the password when > they see the screen has locked? yes. I followed the old KCM in that reguard > - The GUI (just like the 4.x one) does not make clear whether "Require > password after" means "After the last user action" or "After the screen was > locked". I'd write "Require password after locking:". This is still not 100% > clear, but should be more clear than it is now. done > - Is "Logout automatically after" really useful? do we know of realistic > usecases for this feature? Otherwise, I'd remove it. no idea whether it's useful. I can remove it from the UI as it wasn't in the old UI either. I wouldn't mind to remove the feature from the code base either ;-) - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review57524 ----------------------------------------------------------- On May 7, 2014, 5:17 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118038/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 5:17 p.m.) > > > Review request for Plasma and Thomas Pfeiffer. > > > Repository: plasma-workspace > > > Description > ------- > > Bring back a KCM for the screen locker > > Note: I will improve the default values to get them sane. That needs > adjustements in the screenlocker source base and I want to get the review of > the UI started earlier. > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt > 3407ea46d5046f2f5b2e7321d714ad1e65ffceea > ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION > ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION > ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118038/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > KCM with values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png > KCM without values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
