> On May 7, 2014, 5:41 p.m., Sebastian Kügler wrote: > > I think this should go into the plasma-desktop repository, under kcms/ > > (there's already more ksmserver kcm code there). > > > > The spinboxes, I don't find overly useful. Perhaps a combobox with some > > default values to pick from? (Users that absolutely need per-second > > granularity for grace and idle times may edit the config file, IMO.) > > > > The name could be improved, see comment below. The Comment, I'm not quite > > sure about, I don't really like the "configure" bit in there, and it seems > > kind of heavy (it's used as title at the top). Maybe something like > > "Timeouts for Screen Locking"? It's clear from the context that it's about > > "configuration". I'm mulling over the same right now in the new Formats > > (locale) KCM, btw. > > > > Otherwise, it looks nice and clean to me.
plasma-desktop doesn't make much sense coding wise. It's using the kcfg file which is part of the screenlocker/kcfg directory. I think that would just add strange build dependencies if it goes to a different repository. Concerning UI: I do not want to do any specific code which cannot map to kcfg. I see this as a temporary solution as we are late in the cycle and need something. I think the better approach will be to expose the settings from the lock screen once we have it plasma-fied (corona, etc.). But that's post .0 task. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review57503 ----------------------------------------------------------- On May 7, 2014, 5:17 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118038/ > ----------------------------------------------------------- > > (Updated May 7, 2014, 5:17 p.m.) > > > Review request for Plasma and Thomas Pfeiffer. > > > Repository: plasma-workspace > > > Description > ------- > > Bring back a KCM for the screen locker > > Note: I will improve the default values to get them sane. That needs > adjustements in the screenlocker source base and I want to get the review of > the UI started earlier. > > > Diffs > ----- > > ksmserver/screenlocker/CMakeLists.txt > 3407ea46d5046f2f5b2e7321d714ad1e65ffceea > ksmserver/screenlocker/kcm/CMakeLists.txt PRE-CREATION > ksmserver/screenlocker/kcm/kcm.cpp PRE-CREATION > ksmserver/screenlocker/kcm/kcm.ui PRE-CREATION > ksmserver/screenlocker/kcm/screenlocker.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118038/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > KCM with values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/f70f34d6-2c5c-4638-8e43-d9d727fdb7cb__kcm-with-values.png > KCM without values > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/07/89b1ef8e-803f-42fb-b2cb-52b776246598__kcm-without-values.png > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
