> On April 24, 2014, 9:05 a.m., Sebastian Kügler wrote: > > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml, line 87 > > <https://git.reviewboard.kde.org/r/117632/diff/4/?file=267934#file267934line87> > > > > units.largeSpacing / 2 > > > > seems better here. Using konsolePreviewer.height seems rather random to > > me.
I have upload two screenshots. the first one with units.largeSpacing / 2 and the second one with units.largeSpacing / 4. I find that the "/4" is better. What do you think? - Antonis ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/#review56351 ----------------------------------------------------------- On April 24, 2014, 10:21 a.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117632/ > ----------------------------------------------------------- > > (Updated April 24, 2014, 10:21 a.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > This patch enables the konsole and it fixes the spacing. > More info on the screenshots. > > > Diffs > ----- > > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 > > Diff: https://git.reviewboard.kde.org/r/117632/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/8e659a10-f238-440f-b10a-90533880dc99__konsole_spacing-wrong.png > after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/c9bb85d3-4f8e-4b9c-bbbf-bc80f7ccf71b__konsole_spacing-ok.png > units.largeSpacing/2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/e019b5ab-ec1b-453d-a730-ac13d60b4c74__konsole_spacing.png > units.largespacing/4 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/0793b296-9490-47a6-8d43-f3c3653201f4__konsole_spacing_units_large.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
