----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/#review56351 -----------------------------------------------------------
plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml <https://git.reviewboard.kde.org/r/117632/#comment39380> units.largeSpacing / 2 seems better here. Using konsolePreviewer.height seems rather random to me. - Sebastian Kügler On April 23, 2014, 3:23 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117632/ > ----------------------------------------------------------- > > (Updated April 23, 2014, 3:23 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > This patch enables the konsole and it fixes the spacing. > More info on the screenshots. > > > Diffs > ----- > > plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 > > Diff: https://git.reviewboard.kde.org/r/117632/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/8e659a10-f238-440f-b10a-90533880dc99__konsole_spacing-wrong.png > after > > https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/c9bb85d3-4f8e-4b9c-bbbf-bc80f7ccf71b__konsole_spacing-ok.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
