----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55183 -----------------------------------------------------------
I still do not understand the rational behind the change. Could you please explain why we would want this build option? - Martin Gräßlin On April 7, 2014, 4:50 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117393/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 4:50 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Add option to disable building tests, and move the QtTest dependency to be > required only for tests. > > > Diffs > ----- > > CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 > autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 > kcmkwin/kwincompositing/CMakeLists.txt > 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 > kcmkwin/kwincompositing/test/CMakeLists.txt PRE-CREATION > libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 > libkwineffects/autotests/CMakeLists.txt > 8973545cc21b010f1430cf7df20a29da5b14ab43 > tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e > tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 > > Diff: https://git.reviewboard.kde.org/r/117393/diff/ > > > Testing > ------- > > Builds. Tests pass (when enabled). > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
