-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116117/#review51915
-----------------------------------------------------------


This review has been submitted with commit 
f3b9bb2b46236683186cf5b92de383c968d51f81 by Jan Grulich to branch KDE/4.11.

- Commit Hook


On March 4, 2014, 5:07 p.m., Jan Grulich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116117/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 5:07 p.m.)
> 
> 
> Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and 
> Sebastian Kügler.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> When adding a new empty panel, it's placed at top by default, but it should 
> be placed to bottom, when it's possible. Also when adding a new "Default 
> Panel" to second screen without any panel and you already have one on your 
> first screen, then it's also placed to top instead of bottom. This is just a 
> simple fix, which changes order of checking free edges for empty panels and 
> adds a check for screenId when executing a script for default panel layout. 
> I'm not much sure with the javascript part, but it works.
> 
> 
> Diffs
> -----
> 
>   
> plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js
>  356e689 
> 
> Diff: https://git.reviewboard.kde.org/r/116117/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to