----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116117/#review51421 -----------------------------------------------------------
Ship it! plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js <https://git.reviewboard.kde.org/r/116117/#comment36210> numberOfPanelsOnScreen might be a clearer variable name, as the number of panels is clearly panelIds.length - David Edmundson On March 1, 2014, 11:47 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116117/ > ----------------------------------------------------------- > > (Updated March 1, 2014, 11:47 a.m.) > > > Review request for kde-workspace, Plasma, Aaron J. Seigo, Marco Martin, and > Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > When adding a new empty panel, it's placed at top by default, but it should > be placed to bottom, when it's possible. Also when adding a new "Default > Panel" to second screen without any panel and you already have one on your > first screen, then it's also placed to top instead of bottom. This is just a > simple fix, which changes order of checking free edges for empty panels and > adds a check for screenId when executing a script for default panel layout. > I'm not much sure with the javascript part, but it works. > > > Diffs > ----- > > > plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js > 47f635c > plasma/desktop/shell/desktopcorona.cpp d3635d9 > > Diff: https://git.reviewboard.kde.org/r/116117/diff/ > > > Testing > ------- > > > Thanks, > > Jan Grulich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
