----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116024/#review51129 -----------------------------------------------------------
src/declarativeimports/core/fadingnode.cpp <https://git.reviewboard.kde.org/r/116024/#comment35847> Despite my code being clearly right this doesn't work. (according to apitrace and then qDebug) oldState is always 0 This means we are binding textures every frame, which is what we wanted to avoid. I'm quite confused as to why. - David Edmundson On Feb. 27, 2014, 1:44 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116024/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 1:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Port IconItem to native QSGTexture including the animation. > This will save constantly uploading a new texture to OpenGL throughout the > animation. > > > Diffs > ----- > > CMakeLists.txt 4bc47bf > src/declarativeimports/core/CMakeLists.txt 97e9283 > src/declarativeimports/core/fadingnode.cpp PRE-CREATION > src/declarativeimports/core/fadingnode_p.h PRE-CREATION > src/declarativeimports/core/iconitem.h 26ee410 > src/declarativeimports/core/iconitem.cpp fed2f9b > > Diff: https://git.reviewboard.kde.org/r/116024/diff/ > > > Testing > ------- > > Test app: http://paste.kde.org/pl5pwdnel > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
