----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114253/#review45225 -----------------------------------------------------------
This review has been submitted with commit 5bf3928ec160f92dcfc1ad70fd9832e4f03594d3 by Andrea Scarpino to branch master. - Commit Hook On Dec. 5, 2013, 6:01 p.m., Andrea Scarpino wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114253/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 6:01 p.m.) > > > Review request for Plasma. > > > Repository: kde-workspace > > > Description > ------- > > I replaced KUrl by QUrl and KStandardDirs by QStandardPaths. Also I cleanup > includes. > > The url given in input could be absolute or relative but not local, then I > used QUrl::fromUserInput(). > > > Diffs > ----- > > plasma/generic/dataengines/favicons/favicons.cpp 2eae673 > plasma/generic/dataengines/favicons/favicons.h 79565bf > plasma/generic/dataengines/favicons/faviconprovider.cpp bc72a66 > plasma/generic/dataengines/favicons/faviconprovider.h 1f370f9 > plasma/generic/dataengines/CMakeLists.txt 3e94325 > plasma/generic/dataengines/favicons/CMakeLists.txt 4af0f14 > > Diff: http://git.reviewboard.kde.org/r/114253/diff/ > > > Testing > ------- > > If I try to fetch several favicons an empty image is returned, except the > first one which contains a valid favicon. > > > Thanks, > > Andrea Scarpino > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
